Skip to content

docs: add missing ) to id-denylist#19213

Merged
mdjermanovic merged 2 commits intoeslint:mainfrom
lumirlumir:docs-add-missing-id-denylist
Dec 4, 2024
Merged

docs: add missing ) to id-denylist#19213
mdjermanovic merged 2 commits intoeslint:mainfrom
lumirlumir:docs-add-missing-id-denylist

Conversation

@lumirlumir
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir commented Dec 4, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I've added missing ) to id-denylist.md. I think that there should be ).

image

Is there anything you'd like reviewers to focus on?

Nothing.

@lumirlumir lumirlumir requested a review from a team as a code owner December 4, 2024 14:28
@eslint-github-bot eslint-github-bot Bot added the documentation Relates to ESLint's documentation label Dec 4, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 980b270
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6750676248ee0800070086ca
😎 Deploy Preview https://deploy-preview-19213--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 4, 2024
Copy link
Copy Markdown
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title docs: add missing ) to id-denylist.md docs: add missing ) to id-denylist Dec 4, 2024
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 045d716 into eslint:main Dec 4, 2024
@lumirlumir lumirlumir deleted the docs-add-missing-id-denylist branch December 4, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants