Merged
Conversation
This PR fixes salesforce#222 by: - introducing a fallback for the `util.*` code paths used as indicated in [this comment](salesforce#222 (comment)) - adding a dependency on `url-parse` to act as a polyfill for the usage of `require('url').parse`
This PR fixes salesforce#222 by: - introducing a fallback for the `util.*` code paths used as indicated in [this comment](salesforce#222 (comment)) - adding a dependency on `url-parse` to act as a polyfill for the usage of `require('url').parse` - configuring eslint to error on `no-restricted-modules` which will not be present in native environments
wjhsf
requested changes
Nov 24, 2021
Contributor
wjhsf
left a comment
wjhsf
left a comment
There was a problem hiding this comment.
With this change, the output of inspect for any MemoryCookieStore is always { idx: }. I've commented with a few ways that we might be able to avoid losing information.
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Implementation for the fallback inspect function so that it produces equivalent output to the original inspect behavior.
Implementation for the fallback inspect function so that it produces equivalent output to the original inspect behavior.
wjhsf
requested changes
Nov 29, 2021
Implementation for the fallback inspect function so that it produces equivalent output to the original inspect behavior.
Implementation for the fallback inspect function so that it produces equivalent output to the original inspect behavior.
wjhsf
previously approved these changes
Dec 2, 2021
Member
|
I'll try and find some time this week to do the review; thank you so much for the submission! |
awaterma
reviewed
Jan 10, 2022
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
Just had a question about one of the unit tests ...
reworded some of the test names to make the intent clearer
wjhsf
previously approved these changes
Jan 12, 2022
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
wjhsf
previously approved these changes
Jan 13, 2022
|
@ruoho-sfdc - please review |
Member
|
I think this is ready for merge @colincasey. Nice work! |
awaterma
approved these changes
Mar 4, 2022
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
Approved -- merged with latest update of universalify from Snyk.
wjhsf
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #222 by:
utilmodule code paths used as indicated in this commenturl-parseto act as a polyfill for the usage ofrequire('url').parseno-restricted-moduleswhich will not be present in native environments