Skip to content

Initial documentation review#234

Merged
wjhsf merged 12 commits intosalesforce:masterfrom
mcarey86:master
May 24, 2022
Merged

Initial documentation review#234
wjhsf merged 12 commits intosalesforce:masterfrom
mcarey86:master

Conversation

@mcarey86
Copy link
Copy Markdown
Contributor

@mcarey86 mcarey86 commented Mar 7, 2022

No description provided.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
@wjhsf wjhsf mentioned this pull request Apr 7, 2022
wjhsf
wjhsf previously approved these changes Apr 7, 2022
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
mcarey86 and others added 5 commits May 23, 2022 10:13
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
wjhsf
wjhsf previously approved these changes May 23, 2022
Copy link
Copy Markdown
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor comment regarding expiryTime(); outside of that looks good to me!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Copy link
Copy Markdown
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wjhsf wjhsf merged commit b8d7511 into salesforce:master May 24, 2022
wjhsf pushed a commit that referenced this pull request Feb 8, 2024
…utomocks (#234)

fixes #232

This PR reverts #231, #210, and #208. They provided functionality to auto mock apex methods.

**Note:** Test authors will need to keep implementing their own apex (+apexContinuation) methods mocks after this PR is merged.

* Revert "fix: apex automock should return a resolved promise (#231)"

This reverts commit 544f95a.

* Revert "fix: add apex stubs to the transformIgnorePatterns (#210)"

This reverts commit fe8381a.

* Revert "fix: automock apex methods with valid wire adapters (#208)"

This reverts commit 125c689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants