Stop using the internal NodeJS punycode module#238
Merged
colincasey merged 1 commit intosalesforce:masterfrom May 23, 2022
Merged
Stop using the internal NodeJS punycode module#238colincasey merged 1 commit intosalesforce:masterfrom
colincasey merged 1 commit intosalesforce:masterfrom
Conversation
…unycode package (also because the internal punycode NodeJS module is deprecated)
colincasey
approved these changes
May 23, 2022
Contributor
Author
|
@colincasey any way we can get a new release out? I see there's actually quite a number of things fixed that aren't released yet. If there's something I can do, let me know! |
Contributor
Contributor
Author
|
Great! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the code is right now, it doesn't use the Punycode package, but the internal NodeJS punycode module. That is deprecated now, which is why I saw the warning popping up (for the ones googling this, the warning is
[DEP0040] DeprecationWarning: The 'punycode' module is deprecated. Please use a userland alternative instead). According to the docs of the Punycode package, you need to userequire('punycode/'), to use the Punycode package rather than the internal NodeJS module, see https://github.com/mathiasbynens/punycode.js#installation.