Fix misleading on npm install with git url#64
Merged
zkat merged 1 commit intonpm:release-nextfrom Nov 13, 2018
zckrs:patch-1
Merged
Fix misleading on npm install with git url#64zkat merged 1 commit intonpm:release-nextfrom zckrs:patch-1
zkat merged 1 commit intonpm:release-nextfrom
zckrs:patch-1
Conversation
neverett
reviewed
Aug 31, 2018
With some tests I note npm use default branch of repository instead of `master`.
Author
zkat
approved these changes
Nov 13, 2018
Contributor
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
Nice! Thanks for catching this, and this should totally be the case now.
zkat
pushed a commit
that referenced
this pull request
Dec 10, 2018
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
* feat: smarter truncation of method/resource descriptions - Add shared truncate_description() in src/text.rs with configurable limits and optional markdown link stripping - Named constants: CLI_DESCRIPTION_LIMIT (200), FRONTMATTER_DESCRIPTION_LIMIT (120), SKILL_BODY_DESCRIPTION_LIMIT (500) - CLI help and frontmatter strip markdown links to save space - Skill body preserves URLs so agents can follow references - Truncation prefers sentence boundaries, falls back to word boundaries - Reads full descriptions from discovery doc for skill body text Fixes npm#64 * fix: address PR review comments and improve coverage - Fix sentence boundary detection at exact end of prefix (HIGH) - Use extend() for link text emission (MEDIUM) - Idiomatic find_char_from with position/map (MEDIUM) - Idiomatic rfind_char_boundary with rposition (MEDIUM) - Add 18 new tests for generate_skills.rs coverage: truncate_desc, lookup_method_description, capitalize_first, product_name_from_title - Add sentence_boundary_at_exact_limit and zero_max_chars tests --------- Co-authored-by: jpoehnelt-bot <jpoehnelt-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some tests I note npm use default branch of repository instead of
master.