Repository navigation
[6.x] Fix nocache directory permissions - #15762
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the
storage/statamic/tmp/nocachedirectory is always created with0755permissions, which prevents nocache fragments from being written when CLI and web processes run as different users and share access through group permissions or ACLs.This was happening because #15363 moved nocache fragments from
storage/framework/views(which Laravel creates with0777, leaving the umask to decide) intostorage/statamic/tmp/nocache, which was created viaFile::makeDirectory(). Statamic's filesystem adapter hardcodes0755, stripping group write regardless of the umask.This PR fixes it by creating the nocache directory with
0777, matching Laravel's compiled views directory, so the umask decides the final permissions.Fixes #15566
Caused by #15363