Add Site Health test to verify that static assets are served with far-future expires - #1727
Merged
westonruter merged 34 commits intoJan 22, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #323
Relevant technical choices
Test are based on the
Cache-Controlwithmax-ageor anExpiresto determine if the static assets are served with far future expires. IfCache-ControlandExpiresare unavailable then theETagandLast-Modifiedare used to do a secondary request to the same asset URL withIf-None-MatchandIf-Modified-Since, respectively. If those return with 304 Not Modified then that could pass the test as well.