Skip to content

Coding Standards: Fix alignment of assignment operators - #12858

Closed
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:coding-standards/fix-assignment-alignment
Closed

Coding Standards: Fix alignment of assignment operators#12858
Soean wants to merge 1 commit into
WordPress:trunkfrom
Soean:coding-standards/fix-assignment-alignment

Conversation

@Soean

@Soean Soean commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

composer run format currently reports two Generic.Formatting.MultipleStatementAlignment warnings. This PR applies the auto-fixes so that a clean checkout of trunk passes without pending changes.

Warnings

FILE: src/wp-admin/includes/class-wp-users-list-table.php
 638 | WARNING | [x] Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

FILE: src/wp-includes/pluggable.php
2379 | WARNING | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces

When were these introduced?

Both were introduced during the 7.1 development cycle, so no released version of WordPress is affected.

File Introduced in Ticket
src/wp-admin/includes/class-wp-users-list-table.php r62838Administration: Use post title column as table header in post lists (2026-07-23) #32892
src/wp-includes/pluggable.php r62590Notifications: Remove the username from the new user notification email (2026-06-30) #63085

In r62838 the new $tag assignment was added directly above an existing $row .= assignment without aligning the block. In r62590 the line above $message was removed, leaving $message with the alignment padding of a block that no longer exists.

These are whitespace-only changes, so no functional testing is required.

Trac ticket: https://core.trac.wordpress.org/ticket/64897


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Fixes two `Generic.Formatting.MultipleStatementAlignment` warnings introduced during the 7.1 cycle
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@SergeyBiryukov

Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r63027.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants