Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.09] Fix long startup on windows, with non-hns governed Hyper-V networks - #67

Merged
thaJeztah merged 1 commit into
docker-archive:18.09from
thaJeztah:18.09_backport_windows-network-plugin-miss-fix
Oct 3, 2018
Merged

[18.09] Fix long startup on windows, with non-hns governed Hyper-V networks#67
thaJeztah merged 1 commit into
docker-archive:18.09from
thaJeztah:18.09_backport_windows-network-plugin-miss-fix

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Backport of moby#37774 for 18.09

git checkout -b 18.09_backport_windows-network-plugin-miss-fix ce-engine/18.09
git cherry-pick -s -S -x 6a1a4f97217b0a8635bc21fc86628f48bf8824d1
git push -u origin

cherry-pick was clean; no conflicts

Similar to a related issue where previously, private Hyper-V networks
would each add 15 secs to the daemon startup, non-hns governed internal
networks are reported by hns as network type "internal" which is not
mapped to any network plugin (and thus we get the same plugin load retry
loop as before).

This issue hits Docker for Desktop because we setup such a network for
the Linux VM communication.

Similar to a related issue where previously, private Hyper-V networks
would each add 15 secs to the daemon startup, non-hns governed internal
networks are reported by hns as network type "internal" which is not
mapped to any network plugin (and thus we get the same plugin load retry
loop as before).

This issue hits Docker for Desktop because we setup such a network for
the Linux VM communication.

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
(cherry picked from commit 6a1a4f9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.0 milestone Oct 3, 2018
@thaJeztah

Copy link
Copy Markdown
Member Author

ping @simonferquel @vdemeester

@vdemeester vdemeester left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@simonferquel

Copy link
Copy Markdown

LGTM

@thaJeztah
thaJeztah merged commit 6e5ed2c into docker-archive:18.09 Oct 3, 2018
@thaJeztah
thaJeztah deleted the 18.09_backport_windows-network-plugin-miss-fix branch October 3, 2018 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants