Skip to content

feat(bigquery): expose StatementType and query execution stats on TableResult - #14145

Merged
keshavdandeva merged 4 commits into
mainfrom
bq-expose-statement-type
Aug 21, 2026
Merged

feat(bigquery): expose StatementType and query execution stats on TableResult#14145
keshavdandeva merged 4 commits into
mainfrom
bq-expose-statement-type

Conversation

@keshavdandeva

@keshavdandeva keshavdandeva commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

b/549680449

This PR exposes StatementType and jobless query execution metrics on TableResult by plumbing them from QueryResponse and JobStatistics.QueryStatistics.

This enables downstream consumers (such as the BigQuery JDBC driver) to inspect query statement types and execution statistics directly from TableResult without needing to issue secondary jobs or dry-run queries.

Changes

  • Dependency Update: Bumped google-api-services-bigquery to v2-rev20260731-2.0.0 in google-cloud-jar-parent/pom.xml and java-bigquery/pom.xml.
  • TableResult: Added getters, builder setters, pagination propagation (getNextPage()), toString(), hashCode(), and equals() for:
    • getStatementType() (StatementType)
    • getTotalBytesBilled() (Long)
    • getTotalBytesProcessed() (Long)
    • getTotalSlotMs() (Long)
    • getNumDmlAffectedRows() (Long)
  • BigQueryImpl: Plumbed these fields from QueryResponse when building TableResult in queryRpc().
  • Job: Plumbed StatementType and query metrics from QueryStatistics when creating TableResult in getQueryResults().
  • Tests: Added unit tests in TableResultTest and BigQueryImplTest verifying field retrieval, pagination propagation, builder modifications, and serialization.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery dependency version and propagates query execution statistics—including statement type, total bytes billed, total bytes processed, total slot milliseconds, and affected DML rows—from query results and job statistics into the TableResult object. The review feedback suggests wrapping the StatementType.valueOf() conversion in a try-catch block to gracefully handle any unrecognized statement types returned by the BigQuery service and prevent runtime exceptions.

Comment thread java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
@keshavdandeva
keshavdandeva marked this pull request as ready for review August 20, 2026 14:52
@keshavdandeva
keshavdandeva requested review from a team as code owners August 20, 2026 14:52
@lqiu96

lqiu96 commented Aug 20, 2026

Copy link
Copy Markdown
Member

@keshavdandeva FYI, I'm going to upgrade the bigquery apiary version in #14149

@keshavdandeva
keshavdandeva requested a review from lqiu96 August 20, 2026 22:17
@keshavdandeva
keshavdandeva force-pushed the bq-expose-statement-type branch from b333559 to 94fbc07 Compare August 20, 2026 22:33
@keshavdandeva
keshavdandeva marked this pull request as draft August 21, 2026 16:34
@keshavdandeva
keshavdandeva force-pushed the bq-expose-statement-type branch from 94fbc07 to d4f4546 Compare August 21, 2026 17:19
@keshavdandeva

keshavdandeva commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery client to expose additional query statistics and session information (such as statement type, bytes billed/processed, slot milliseconds, affected DML rows, and session info) in TableResult, along with updating the BigQuery API dependency version and adding corresponding unit tests. Feedback was provided to wrap the StatementType.valueOf conversion in a try-catch block to prevent runtime crashes if the backend returns an unrecognized statement type.

Comment thread java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
@keshavdandeva
keshavdandeva marked this pull request as ready for review August 21, 2026 17:24
Neenu1995
Neenu1995 reviewed Aug 21, 2026
View reviewed changes
Comment thread java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java Outdated

public abstract TableResult.Builder setNumDmlAffectedRows(Long numDmlAffectedRows);

public abstract TableResult.Builder setSessionInfo(SessionInfo sessionInfo);

@Neenu1995 Neenu1995 Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an IT test to verify that this values is getting propagated from the backend correctly.

@keshavdandeva
keshavdandeva requested a review from lqiu96 August 21, 2026 18:04
lqiu96
lqiu96 approved these changes Aug 21, 2026
View reviewed changes

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small nit, but LGTM otherwise

@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2026
@keshavdandeva
keshavdandeva merged commit 7d16de8 into main Aug 21, 2026
209 of 210 checks passed
@keshavdandeva
keshavdandeva deleted the bq-expose-statement-type branch August 21, 2026 20:15
This was referenced Aug 24, 2026
Closed
Merged
lqiu96 pushed a commit that referenced this pull request Aug 24, 2026
@release-please
chore(main): release 1.90.0 (#14173)
8cbbb56 
🤖 I have created a release *beep* *boop*
---


<details><summary>1.90.0</summary>

##
[1.90.0](v1.89.0...v1.90.0)
(2026-08-24)


### Features

* **bigquery-jdbc:** implement TypeRegistry and TypeDescriptor
([#13947](#13947))
([0557e69](0557e69))
* **bigquery:** add QueryResultsFormat and ArrowSerializationOptions
configurations
([#13942](#13942))
([ff03e19](ff03e19))
* **bigquery:** expose `StatementType` and query execution stats on
`TableResult`
([#14145](#14145))
([7d16de8](7d16de8))
* **bigtable:** enable microsecond timestamps in client
([#14057](#14057))
([57aaf8d](57aaf8d))
* **bigtable:** route single-entry MutateRows through a point-write c…
([#14028](#14028))
([a403703](a403703))
* **datastore:** add support for request tags
([#13732](#13732))
([b1f6186](b1f6186))
* **ftp:** onboard a new library
([#14068](#14068))
([f41b2d9](f41b2d9))
* **gax:** add ResumableUploadCallable and ResumableUploadCallSettings
([#14052](#14052))
([a5e26e8](a5e26e8))
* **google/cloud/biglake/hive/v1:** onboard a new library
([#14130](#14130))
([650c839](650c839))
* **google/maps/mapmanagement/v2:** onboard a new library
([#14131](#14131))
([7d00726](7d00726))
* **spanner:** support user-provided OpenTelemetry for client metrics
export
([#13741](#13741))
([da74dee](da74dee))
* update API sources and regenerate
([#14000](#14000))
([9337a93](9337a93))
* **workloadidentity:** onboard a new library
([#14060](#14060))
([ab226ee](ab226ee))


### Bug Fixes

* add documentation for insertall api that there's no default retry
([#13953](#13953))
([1fdb4f1](1fdb4f1))
* add retry behavior documentation to insertall interface to clarify the
behavior
([#14058](#14058))
([1b8f9e3](1b8f9e3))
* **auth:** fix JSpecify nullability in UserAuthorizer and TokenStore
([#14150](#14150))
([0d5fac0](0d5fac0))
* **auth:** fix remaining nullability in UserAuthorizer and Builder
([#14158](#14158))
([a51bb8d](a51bb8d))
* **auth:** refine JSpecify nullability for ServiceAccountCredentials
and UserCredentials
([#14159](#14159))
([a929250](a929250))
* **bigquery-jdbc:** enable ITOpenTelemetryTest
([#13991](#13991))
([fa6641b](fa6641b))
* **bigquery-jdbc:** pass connection proxy settings to OpenTelemetry
exporters
([#14011](#14011))
([115b9b3](115b9b3))
* **bigquery-jdbc:** session context propagation when session is enabled
([#14161](#14161))
([1e74dda](1e74dda))
* **bigtable:** remove heartbeat miss logging
([#14054](#14054))
([ec17637](ec17637))
* **deps:** update dependency
com.google.apis:google-api-services-bigquery to v2-rev20260731-2.0.0
([#14149](#14149))
([95f6c38](95f6c38))
* **deps:** update dependency com.google.cloud:libraries-bom to v26.86.0
([#14103](#14103))
([cf5697e](cf5697e))
* **gax-httpjson:** reduce Conscrypt fallback error to debug level
([#13962](#13962))
([8236771](8236771))
* **gax-httpjson:** remove unsupported and deprecated PQC named groups
([#14107](#14107))
([7604971](7604971))
* **gax:** register Conscrypt SSLContext SPI classes for GraalVM
reflection
([#14129](#14129))
([73c0243](73c0243))
* **samples:** align native profile junit and surefire versions with
shared config
([#14096](#14096))
([2b84133](2b84133))
* **spanner:** add closeAsync to ReadContext and make transaction
closing non-blocking
([#14076](#14076))
([671f892](671f892))
* **spanner:** scope server-timing metrics per call and guard
interceptor lifecycle callbacks
([#14053](#14053))
([f35c570](f35c570))
* **storage:** use JsonUtils for StorageObject serialization in
resumable writes and read channels
([#13976](#13976))
([d94922f](d94922f))


### Performance Improvements

* **bigquery-jdbc:** eliminate dry run to resolve statement type
([#14156](#14156))
([7109ecd](7109ecd))
* **spanner-jdbc:** cache commonly used query parameter names
([#14036](#14036))
([1eb6aa3](1eb6aa3))
* **spanner-jdbc:** cache JDBC metadata query strings
([#14041](#14041))
([31c628f](31c628f))
* **spanner-jdbc:** cache positional to named param conversion
([#14034](#14034))
([30e031b](30e031b))


### Dependencies

* **gax-httpjson:** upgrade conscrypt-openjdk-uber to 2.6.2
([#14117](#14117))
([2f5481a](2f5481a))
* Update gRPC to v1.82.3
([#13997](#13997))
([a786107](a786107))
* Upgrade gRPC to v1.82.4
([#14088](#14088))
([0c482fe](0c482fe))


### Documentation

* **bigquery-jdbc:** add user guide with connection property and custom
endpoint reference
([#13878](#13878))
([2dde172](2dde172))
* **gax:** update LRO troubleshooting documentation link
([#14108](#14108))
([4c5bbae](4c5bbae))
* **spanner-jdbc:** update connection_properties.md documentation
([#14035](#14035))
([b576fe8](b576fe8))
* **spanner:** update CHANGELOG.md for releases 6.117.0 through 6.120.0
([#13970](#13970))
([2413811](2413811))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes
@Neenu1995 Neenu1995 Neenu1995 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keshavdandeva @lqiu96 @Neenu1995 @yoshi-kokoro