Skip to content

fix empty scripts - #2174

Closed
nlf wants to merge 1 commit into
latestfrom
nlf/fix-empty-scripts
Closed

fix empty scripts#2174
nlf wants to merge 1 commit into
latestfrom
nlf/fix-empty-scripts

Conversation

@nlf

@nlf nlf commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

this restores the npm6 behavior where npm run somescript where the script is defined as an empty string simply does nothing, rather than throwing an error that the script does not exist

References

Fixes #2171

@nlf
nlf requested a review from a team as a code owner November 13, 2020 22:17
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 16, 2020
@ruyadorno ruyadorno mentioned this pull request Nov 17, 2020
Merged
@ruyadorno ruyadorno closed this in 7b89576 Nov 17, 2020
@ruyadorno ruyadorno mentioned this pull request Nov 17, 2020
Closed
Robodog63
Robodog63 reviewed Feb 1, 2021
View reviewed changes

@Robodog63 Robodog63 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Nest videos

@nlf
nlf deleted the nlf/fix-empty-scripts branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Robodog63 Robodog63 Robodog63 left review comments
@ruyadorno ruyadorno ruyadorno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NPM 7 fails with an empty script.

4 participants

@nlf @ruyadorno @Robodog63 @darcyclarke