Skip to content

Commit 6eeec69

Browse files
authored
fix(devtools): drop stale visibility assertion from nuxt-group e2e test (#1042)
1 parent 412a33d commit 6eeec69

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

‎tests/e2e/specs/nuxt-group.spec.ts‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,21 @@ test('registers a single `Nuxt` group with `nuxt:devtools` as its default child'
5454
expect(memberIds).toContain('nuxt:devtools:settings')
5555
expect(memberIds.length).toBeGreaterThan(1)
5656

57-
// The anchor's own dock button is redundant next to those members, so it's
58-
// registered with a render-only `visibility: 'false'` (devframe#136): its
59-
// button is suppressed while the entry stays registered — keeping its
60-
// `subTabs`/`frameId` shared iframe alive and driving the nav loop.
57+
// The anchor's own dock button would ideally be suppressed via a
58+
// render-only `visibility: 'false'` (devframe#136) since it's redundant
59+
// next to those members, but that's currently disabled in `module-main.ts`
60+
// — the group button's `defaultChildId` fallback looks the entry up
61+
// through the same visibility filter, so hiding the anchor also breaks
62+
// clicking into it from the `Nuxt` group button. Once that's fixed
63+
// upstream, re-enable `visibility: 'false'` there and restore this
64+
// assertion. Until then, the entry stays registered and visible, keeping
65+
// its `subTabs`/`frameId` shared iframe alive and driving the nav loop.
6166
const anchor = await page.evaluate(() => {
6267
const ctx = (globalThis as any).__VITE_DEVTOOLS_CLIENT_CONTEXT__
6368
return ctx.docks.entries.find((entry: any) => entry.id === 'nuxt:devtools')
6469
})
6570
expect(anchor).toMatchObject({
6671
id: 'nuxt:devtools',
67-
visibility: 'false',
6872
subTabs: { protocol: 'postmessage' },
6973
})
7074
})

0 commit comments

Comments
 (0)