Added min and max filters - #475
Closed
snoack wants to merge 1 commit into
Closed
Conversation
Closed
Merged
Member
|
Continued in #737 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 years ago I suggested to add
minandmaxfilters, along with some other new filters as part of #66. That pull request has been closed, after some parts of it got implemented independently, even though somebody already complained there about these filters having been left out.Also I still think adding these particular filters would be useful, as I've seen quite some projects adding custom filters for these purpose. So it seems to be a quite common use case. Also having them built into jinja2, allows us to support the optional
attributeandcase_sensitiveoptions/semantics used by other built-in filters.