Stabilize WebAssembly atomic intrinsics - #926
Closed
alexcrichton wants to merge 1 commit into
Closed
Conversation
|
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
I sort of forget the precise procedure by which these intrinsics are stabilized, but I'd be happy to write up more information if desired! (or start with an issue elsewhere as well) |
This commit stabilizes the wasm atomic intrinsics now that the threads proposal has advanced to Stage 4, and is shipping in browsers. Unfortunately these intrinsics still aren't available through the precompiled versions of the standard library because atomics are no
alexcrichton
force-pushed
the
stabilize-wasm-threads
branch
from
October 7, 2020 01:11
15c607c to
30c9f35
Compare
Member
Author
|
Looks like LLVM isn't as far along as I thought, so I left in the module being disabled without the |
Member
|
Is there a tracking issue for these? It needs an FCP before it can be stabilized. (rfcbot isn't enabled on this repo). |
Member
Author
|
Ah yes, indeed! I will follow up with a tracking issue in rust-lang/rust and will cc the libs team there. |
Member
Author
|
Ok I opened rust-lang/rust#77839, but upon reflection I don't think stabilization is a good idea at this time, so I'll be leaving it at that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit stabilizes the wasm atomic intrinsics now that the threads
proposal has advanced to Stage 4, and is shipping in browsers.
Unfortunately these intrinsics still aren't available through the
precompiled versions of the standard library because atomics are no
This commit also updates the availability and documentation of theseintrinsics to reflect how they're always available, but they probably
won't work as expected unless shared memory is used (which isn't enabled
by default). This reflects a change in the threads proposal from the
last year or so where the instructions validate without requiring a
shared memory.