Use SliceIndex trait for SmallVec's Index trait - #166
Closed
sugar700 wants to merge 1 commit into
Closed
Conversation
Requires Rust 1.28.0.
sugar700
force-pushed
the
use-slice-index
branch
from
October 4, 2019 22:26
304216c to
4f127e5
Compare
emilio
reviewed
Oct 5, 2019
| @@ -1,6 +1,6 @@ | |||
| language: rust | |||
| rust: | |||
| - 1.20.0 | |||
Member
There was a problem hiding this comment.
Then can we make this check for 1.28?
Contributor
Author
There was a problem hiding this comment.
My intent is to merge this alongside #162, if I provided a different version, this would cause a merge conflict.
Contributor
|
☔ The latest upstream changes (presumably #167) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
approved these changes
Oct 19, 2019
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires Rust 1.28.0.
This change is