Repository navigation
Python: Create Terminal Doesn't Use Activate.ps1 in Powershell #6928
Description
Environment data
- VS Code version: 1.37
- Extension version (available under the Extensions sidebar): 2019.8.29288
- OS and version: Windows 10 1903
- Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.3 64-bit
- Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
- Relevant/affected Python packages and their versions: N/A
- Jedi or Language Server? (i.e. what is
"python.jediEnabled"set to; more info How to update the language server to the latest stable version #3977): Jedi
Expected behaviour
Running the Python: Create Terminal command should properly activate my terminal using Activate.ps1
I expect to see this
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.
Try the new cross-platform PowerShell https://aka.ms/pscore6
Loading personal and system profiles took 1881ms.
D:\MyProject [master ≡ +1 ~7 -0 !]> d:/MyProject/venv/Scripts/Activate.ps1
D:\MyProject [master ≡ +1 ~7 -0 !]>
Actual behaviour
The command activates my terminal with activate.bat
This is what I see
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.
Try the new cross-platform PowerShell https://aka.ms/pscore6
Loading personal and system profiles took 1881ms.
D:\MyProject [master ≡ +1 ~7 -0 !]> d:/MyProject/venv/Scripts/activate.bat
D:\MyProject [master ≡ +1 ~7 -0 !]>
Steps to reproduce:
- Run the
Python: Create Terminalcommand.
Reacted by Philippe MacKay, Gabe R. , Arno Gobbin and Dan O'Sullivan
Activity
PhilMacKay commentedon Aug 12, 2019
Hi! I confirm I have the same issue, but with small differences in the environment:
Environment data
It affects Powershell Core 6 as well as Powershell. One possible workaround is to switch default shell to
cmd, but I prefer the flexibility of Powershell.The other option is to stay on version 2019.6.24221, which is not affected by this bug.
DonJayamanne commentedon Aug 12, 2019
Radwan Faci (@rafaci) Philippe MacKay (@PhilMacKay)
Help-> Toggle Developer Tools)ConsoletabClear Consoleicon on the top left)Python: Create TerminalConsoletabconsoleoutput windowThe information helps us identify the type of the shell being detected by the extension.
PhilMacKay commentedon Aug 12, 2019
Don Jayamanne (@DonJayamanne)
I created the environment with this line inside a batch script:
py -3.7-64 -m venv --clear --copies ..\\envMyProjectBy following your instructions, I have the following output. Seems like the core of the problem comes from the following:
[Error: [ms-python.python]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api ms-python.pythonNotice, however, that when using the command
Terminal: Create New Integrated Terminal, the virtual environment is correctly activated using the.ps1script.rafaci commentedon Aug 15, 2019
Here's the output I get for version 2019.8.30787 (broken)
Here's the output I get with version 2019.6.24221 (working)
marsfan commentedon Aug 16, 2019
Just want to add to this I have been having the same issue.
Perhaps the best way to fix this would be to call venv/Scripts/activate as opposed to activate.ps1 or activate.bat, as this file will be present irregardless of what terminal is being used to activate the venv, and always works (in my experience) I have looked at the source for this extension as I have considered changing this myself, but I do not know typescript, and cannot figure out how I would do this myself.
DonJayamanne commentedon Aug 16, 2019
Philippe MacKay (@PhilMacKay) Please could you try upgrading your version of VS Code to the latest version (1.37)
PhilMacKay commentedon Aug 19, 2019
Gladly! Here is the log using
venvfor virtual environment"terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe":Same thing but with PowerShell Core 6 (
"terminal.integrated.shell.windows": "C:\\Program Files\\PowerShell\\6\\pwsh.exe")silverches commentedon Aug 20, 2019
I seem to be having the same issue
Environment data
PhilMacKay commentedon Sep 3, 2019
Hello! I did some digging tonight with the code pulled from github.
The issue seems to be related to the
shellDetectorthat works based on the name of the terminal. If it doesn't have a match, it returns the value "other", which is then considered a success on line 57 of the same file.By changing the test condition from
if (shell) {toif (shell && shell !== 'other') {, the detection is considered failed and the next detectors can be used. It leads to a correct detection of the shell type, therefore the correct "activate" script is used.I don't know if the test condition in the
identifyTerminalShellneeds to be modified, or if it's the shell detector itself that should returnundefinedinstead of the value "other"...Anyways, I hope this helps! I would make a pull request but my modification actually breaks two unit tests:
Interpreters Known Paths
Ensure known list of paths are returned on non-windows
Ensure PATH variable and known list of paths are merged on non-windows
Thanks for the help!
1 remaining item
karrtikr commentedon Sep 18, 2019
validated