Repository navigation
Conversation
7333116 to
6f604a2
Compare
|
|
||
| public Text toNative(Component component) { | ||
| return Text.Serializer.fromJson(GsonComponentSerializer.gson().serialize(component)); | ||
| return Text.Serializer.fromJson(LEGACY_JSON.serialize(component)); |
There was a problem hiding this comment.
🟠 [P1] Preserve messages with unsupported hover content
On 1.8.9, a text component whose show_text hover contains Component.keybind("key.jump") now throws JsonParseException: the new serializer exposes the nested keybind to a parser that does not support it. Previously, the label rendered while the hover was ignored. The exception reaches chat display and UI text resolution and can crash the client. Fall back to compatible hover content or preserve the label when conversion fails.
| @@ -1,2 +1,3 @@ | |||
| ## Unreleased changes | |||
| - Fixed hover and click events being dropped from chat messages that OneConfig converts on 1.8.9 | |||
There was a problem hiding this comment.
🔵 [P3] Qualify the release note
Item and entity hovers are still dropped because the selected serializer does not emit their legacy payloads by default. That limitation predates this change, but the new entry suggests converted hover events are fixed generally. Narrow the claim or add support for those hover types.
Description
On 1.8.9,
FabricClientAudiencesserializes withGsonComponentSerializer.gson(), which writeshover_event/click_event. 1.8.9 only readshoverEvent/clickEvent, so hover and click events are dropped from converted chat messages. This switches it tocolorDownsamplingGson(), which writes the format 1.8.9 reads.Checklist