🐛 FIX: commands reject unknown options

Organ Pulse's agent read the current AGENTS.md, ran render --tracks on a
binary built before it, and got the whole song with no error; --bogus
passed too. Each command now lists the options it takes and fails on
anything else.

Author: austinginder

CHANGELOG.md

@@ -82,6 +82,9 @@ All notable changes to Wavelength. Versions follow semantic versioning.
   wrecks the track's loudness reading: those samples are muted and the track warns with the time.
 
 ### Changed
+- Every command rejects options it doesn't know, naming the ones it takes. They used to be
+  ignored: an agent with newer docs than its binary ran `render --tracks` and silently got the
+  whole song.
 - The limiter's warning adds its gain reduction per marker section (average and maximum), so the
   drops' limiting shows next to the quiet sections'.
 - A master `loudness` target now adds its gain in front of the chain's last built-in `limiter`

src/main.cpp

@@ -835,6 +835,28 @@ int run(int argc, char **argv) {
         std::fflush(OUT);
         platform::quickExit(0);   // skip plugin static destructors, which some plugins crash in
     }
+    {   // an option a command doesn't know is an error: a typo (or a newer flag on an older binary) must not be ignored
+        static const std::map<std::string, std::set<std::string>> known = {
+            {"plugins", {"--rescan", "--json", "--block", "--unblock", "--reason"}},
+            {"params", {"--preset", "--state", "--format", "--all", "--json", "--verbose"}},
+            {"presets", {"--search", "--rescan", "--json"}},
+            {"samples", {"--search", "--kit", "--roundrobin", "--json"}},
+            {"analyze", {"--start", "--end", "--song-time", "--grid", "--div", "--json"}},
+            {"audition", {"--jobs", "--limit", "--rebuild", "--retag", "--json", "--verbose"}},
+            {"render", {"--out", "--stems", "--jobs", "--tracks", "--json", "--verbose"}},
+            {"master", {"--chain", "--loudness", "--lead-in", "--input-lead-in", "--out", "--json", "--verbose"}},
+            {"state", {"--out", "--preset", "--state", "--format", "--json", "--verbose"}},
+            {"lint", {"--tracks", "--low", "--crossings", "--json"}},
+            {"version", {"--json"}}};
+        auto it = known.find(cmd);
+        if (it != known.end())
+            for (auto &[k, v] : a.opts)
+                if (!it->second.count(k)) {
+                    std::string list;
+                    for (auto &o : it->second) list += (list.empty() ? "" : " ") + o;
+                    return fail(a, "unknown option " + k + " for `" + cmd + "` (it takes: " + list + (cmd == "state" ? " --set" : "") + ")");
+                }
+    }
     try {
         if (cmd == "plugins") return cmdPlugins(a);
         if (cmd == "params") return cmdParams(a);