Repository navigation
Rename PredicateKind::NormalizesTo to SelectAssocCandidate - #165191
Open
julianbraha wants to merge 2 commits into
Open
julianbraha wants to merge 2 commits into
julianbraha wants to merge 2 commits into
Conversation
This comment about AND and RHS has been stale since: commit 1fcbaf2 ("Handle trait projections").
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @lcnr (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. |
| } = root; | ||
| // If there's a normalizes-to goal, AND the evaluation result with the result of | ||
| // constraining the normalizes-to RHS and computing the nested goals. | ||
|
|
Member
There was a problem hiding this comment.
We should preserve this comment with the renamed term
Member
There was a problem hiding this comment.
Would be nice to have relevant test names updated as well
Contributor
|
r? ShoyuVanilla |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's rename
NormalizesTotoSelectAssocCandidate, as lcnr suggested in this zulip thread.Also, one of the comments about
NormalizesTowas actually stale, so the second commit simply removes it.Note that this PR does not make the other suggested renaming in that zulip thread:
AliasKind::ProjectiontoAliasKind::TraitAssoc[Ty|Const].r? @lcnr