Repository navigation
Conversation
Collaborator
|
Some changes occurred in cc @Amanieu, @folkertdev, @sayantn |
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
With std_detect being able to put a runtime check for FreeBSD, Windows, and macOS, "... are only supported on linux-based platforms" is inaccurate. Also, what "support" means was confusing: it was unclear whether it was talking about the result of the runtime check, or whether the macro could provide a runtime check at all. I don't think it's useful to talk about the result of the runtime detection because the main point of this macro is to determine the result at runtime. Amend to talk about the fallback behavior for miss runtime implementation.
XrXr
force-pushed
the
std-detect-linux-docs
branch
from
October 31, 2026 18:28
a880c02 to
c7ce345
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With std_detect being able to put a runtime check for FreeBSD, Windows,
and macOS, "... are only supported on linux-based platforms" is inaccurate.
Also, what "support" means was confusing: it was unclear whether it was
talking about the result of the runtime check, or whether the macro
could provide a runtime check at all.
I don't think it's useful to talk about the result of the runtime
detection because the main point of this macro is to determine the
result at runtime.
Amend to talk about the fallback behavior for miss runtime implementation.
Alternative sugguestion would be to delete the whole paragraph.