Repository navigation
Don't suggest blanket impls with unconstrained parameters - #165442
Open
vignesh-chaturvedi wants to merge 1 commit into
Open
vignesh-chaturvedi wants to merge 1 commit into
vignesh-chaturvedi wants to merge 1 commit into
Conversation
Avoid suggesting blanket impls when replacing the trait object would leave generic parameters unconstrained, resulting in E0207.
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @jieyouxu (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
workingjubilee
added
the
llm-assisted
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101174
The "alternatively use a blanket implementation" suggestion on E0782 and the
bare_trait_objectswarning could produce an invalid impl. For example, convertingTrait<U>intoT: Trait<U>leavesUunconstrained when it isn't used in the implemented trait, resulting in E0207.This change only shows the suggestion when every type or const parameter in the trait object's generic arguments also appears in the implemented trait. Associated-type bindings are not counted, since they remain constrained by the new bound.
Updated the existing test that expected the broken suggestion, and added coverage for cases where the suggestion should be kept (
GenericTraitTwo<T>andIterator<Item = T>) or omitted when a const parameter is used only in the trait object.Assisted-by: LLM