Repository navigation
Implement a few methods for RingBuf - #20197
Merged
Merged
Conversation
Contributor
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
December 24, 2014 11:12
0646db8 to
13be65b
Compare
There was a problem hiding this comment.
This function does not seem to return anything judging by its type notation.
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
December 24, 2014 19:46
13be65b to
8c3436e
Compare
Contributor
|
Done review. |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
from
December 31, 2014 12:55
c6c6946 to
e0c06b7
Compare
Contributor
|
@pczarn I see you've added some commits; is that everything or are you still working on it (basically: should I re-review now?) |
Contributor
Author
|
@gankro that's everything, except for swap_.._remove tests; hope to add them now. |
Contributor
There was a problem hiding this comment.
I think the as *const T should just coerce for free? Still trying to grok when these coercions do or don't kick in, though.
Contributor
|
Okay lgtm modulo nits/tests. |
pczarn
force-pushed
the
ring_buf-collections-reform
branch
3 times, most recently
from
January 3, 2015 00:29
603fadd to
f47dd53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of collections reform part 1 and 2, #18424 and #19986