Skip to content

update offload usage after simplified build pipeline - #3086

Open
sgasho wants to merge 2 commits into
rust-lang:mainfrom
sgasho:update-offload-usage-ptx-elf
Open

sgasho wants to merge 2 commits into
rust-lang:mainfrom
sgasho:update-offload-usage-ptx-elf

Conversation

@sgasho

@sgasho sgasho commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

related: rust-lang/rust#164896

  • simplify build commands by removing --emit=llvm-bc,llvm-ir -Csave-temps
  • pass the linked device image to the host pass

r? ZuseZ4

…Csave-temps and pass the linked device image to the host pass
@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 6, 2026
Comment thread src/offload/usage.md Outdated

@ZuseZ4 ZuseZ4 Nov 6, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a note to replace the target and Host path?

View changes since the review

Comment thread src/offload/usage.md Outdated

@ZuseZ4 ZuseZ4 Nov 6, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use clang/lld anymore, so this can go too :)

View changes since the review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants