Repository navigation
[6.x] Rebuild the nav preferences tree after resetting customizations - #15656
Merged
jasonvarga merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After "Reset Nav Customizations", the request deleted the preference and reloaded the Inertia props, but the page only builds its tree from
navonce on mount. So the tree kept showing the old customized items while the sidebar had already gone back to the defaults.The reload now rebuilds the tree (and the stored initial nav used by "Discard Changes") from the fresh props once it finishes.
I added a vitest for the page that fails without the change.
I used an AI agent (Claude Code) to help with this change.
Fixes #15634