Repository navigation
[6.x] Speed up rendering icons by only importing each one once - #15766
Merged
Merged
Conversation
duncanmcclean
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request speeds up rendering pages with lots of icons, like entries with large Bard or Replicator fields.
Every
<ui-icon>instance dynamically imported its SVG, even when the same icon had already been loaded. Vite's preload helper runs adocument.querySelector()for each of a chunk's dependencies on every dynamic import, which gets expensive on a big page. On a customer's entry (~40k DOM nodes, ~1,400 Bard toolbar buttons), it added up to ~0.5 seconds, and was why Bard's toolbar icons appeared a couple of seconds after the editors.This PR fixes it by remembering each icon's import, so it only happens once per icon. A failed import is forgotten, so it can be retried.
Related: #13385