[6.x] When sets are expanded, add isolation to force a new stacking context.…#14121
Merged
[6.x] When sets are expanded, add isolation to force a new stacking context.…#14121
Conversation
… This means outer Bard toolbars will have a effectively have a higher "z-index" than ones inside, so inner toolbars don't appear above outer ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
contain: paintwrapped around sets.contain: paintwas originally used to prevent overflow in a performant way (it's more performant than simply hiding elements, because it also tells the browser not to even render anything outside the boundaries)contain: paintis that it also creates a new stacking contextWell, it turns out that
contain: painthad both bad and good side effectscontain: paintonly when sets were closed.z-indexvalue.So… removing
contain: paintfor open sets to fix #14007 means that we no longer have that "new stacking context" applied, which in turn means that inner Bard toolbars appear above outer Bard toolbarsWhat this PR Does
contain: paintis still conditionally applied when sets are closed, for maximum rendering performanceisolation: isolate, which creates a new stacking context.How to Reproduce