Skip to content

[6.x] Handle cancelled requests when generating slugs#14211

Merged
jasonvarga merged 1 commit into6.xfrom
slug-generation
Mar 11, 2026
Merged

[6.x] Handle cancelled requests when generating slugs#14211
jasonvarga merged 1 commit into6.xfrom
slug-generation

Conversation

@duncanmcclean
Copy link
Member

This pull request fixes an issue where the slug field would stop updating when typing on slow network connections.

This was happening because when a slug request was cancelled (due to the user continuing to type), the cancelled request's promise was resolving with undefined. This undefined value would then propagate through to Slugify.vue, setting this.slug = undefined. When the to watcher detected this mismatch between the parent's slug value and this.slug, it would set shouldSlugify = false, permanently disabling slug generation until the page is reloaded.

This PR fixes it by allowing cancelled requests to throw their error (instead of returning undefined) and ignoring CanceledError exceptions in Slugify.vue so cancelled requests don't interfere with the slug field state.


Fixes #14206

@duncanmcclean duncanmcclean changed the title Handle cancelled requests when generating slugs [6.x] Handle cancelled requests when generating slugs Mar 11, 2026
@jasonvarga jasonvarga merged commit 1fe1d91 into 6.x Mar 11, 2026
18 of 19 checks passed
@jasonvarga jasonvarga deleted the slug-generation branch March 11, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slug generation crashing with slow network speeds

2 participants