[6.x] Handle cancelled requests when generating slugs#14211
Merged
jasonvarga merged 1 commit into6.xfrom Mar 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the slug field would stop updating when typing on slow network connections.
This was happening because when a slug request was cancelled (due to the user continuing to type), the cancelled request's promise was resolving with
undefined. Thisundefinedvalue would then propagate through toSlugify.vue, settingthis.slug = undefined. When thetowatcher detected this mismatch between the parent's slug value andthis.slug, it would setshouldSlugify = false, permanently disabling slug generation until the page is reloaded.This PR fixes it by allowing cancelled requests to throw their error (instead of returning undefined) and ignoring CanceledError exceptions in
Slugify.vueso cancelled requests don't interfere with the slug field state.Fixes #14206