-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Support loading system certificates with Node #274631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for loading system certificates using Node.js built-in TLS API (tls.getCACertificates('system')) as an alternative to the existing @vscode/proxy-agent implementation. The feature is controlled by a new experimental setting http.systemCertificatesNode.
- Introduces a new configuration option
http.systemCertificatesNode(default: false, experimental) - Updates certificate loading logic in both
RequestServiceandproxyResolverto use Node.js native API when enabled - Updates
@types/nodeto version^22.18.10to support the new TLS API
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/request/common/request.ts | Adds http.systemCertificatesNode setting configuration and includes it in USER_LOCAL_AND_REMOTE_SETTINGS |
| src/vs/platform/request/node/requestService.ts | Implements Node.js-based certificate loading in loadCertificates() method and updates getConfigValue() to support fallback values |
| src/vs/workbench/api/node/proxyResolver.ts | Updates loadAdditionalCertificates to use Node.js system certificates for both remote and local scenarios when the setting is enabled |
| package.json | Updates @types/node dependency to ^22.18.10 |
| package-lock.json | Updates lockfile for @types/node and its dependency undici-types |
|
@chrmarti looks like compile/hygiene failed |
089ec4c to
0cf6b7c
Compare
0cf6b7c to
2197b31
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
#252148