Skip to content

Interactivity API: populate router's state.url in the server#10944

Closed
luisherranz wants to merge 5 commits intoWordPress:trunkfrom
luisherranz:interactivity-router-populate-state-url
Closed

Interactivity API: populate router's state.url in the server#10944
luisherranz wants to merge 5 commits intoWordPress:trunkfrom
luisherranz:interactivity-router-populate-state-url

Conversation

@luisherranz
Copy link
Member

What

This PR populates state.url in the core/router Interactivity API namespace on the server, inside the data-wp-router-region directive processor.

Trac ticket: https://core.trac.wordpress.org/ticket/64649

Why

After Gutenberg PR WordPress/gutenberg#70882, state.url in the interactivity router is no longer unconditionally set to window.location.href on the client. Instead, it falls back to window.location.href only if the server hasn't already provided a value:

state.url = state.url || window.location.href;

This PR provides that server-side value by calling wp_interactivity_state( 'core/router', ... ) during directive processing, following the same URL construction pattern used by redirect_canonical() and get_self_link().

How

  • Adds a wp_interactivity_state( 'core/router', array( 'url' => ... ) ) call inside data_wp_router_region_processor() in WP_Interactivity_API.
  • The URL is constructed using set_url_scheme(), $_SERVER['HTTP_HOST'], and $_SERVER['REQUEST_URI'].

Testing

  1. Create a page with a Query Loop block using enhanced pagination (which uses data-wp-router-region).
  2. View the page source and verify the interactivity script module data JSON includes "core/router" with the "url" property matching the current page URL.
  3. Verify client-side navigation still works correctly.

Use of AI tools

Claude Code was used to research the best way to construct the URL and how other internal WordPress functions do it, and assist in creating the tests.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@luisherranz luisherranz self-assigned this Feb 16, 2026
@github-actions
Copy link

github-actions bot commented Feb 16, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props luisherranz, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

wp_interactivity_state(
'core/router',
array(
'url' => set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . wp_unslash( $_SERVER['REQUEST_URI'] ) ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this just use get_self_link() directly?

Suggested change
'url' => set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . wp_unslash( $_SERVER['REQUEST_URI'] ) ),
'url' => get_self_link(),

This will handle the case where the $_SERVER['HTTP_HOST'] is not set. Granted, core normally assumes it is set, but not always as in redirect_canonical():

if ( ! $requested_url && isset( $_SERVER['HTTP_HOST'] ) ) {
// Build the URL in the address bar.
$requested_url = is_ssl() ? 'https://' : 'http://';
$requested_url .= $_SERVER['HTTP_HOST'];
$requested_url .= $_SERVER['REQUEST_URI'];
}

Using get_self_link() will also account for a port number other than the default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, I thought that function was related to feeds.

Returns the link for the currently displayed feed.

https://developer.wordpress.org/reference/functions/get_self_link/

But I'll gladly update the code to use it instead 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e2ab11e.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Well, it's applicable to more than just feeds. We should probably update the description to indicate this at some point.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61659
GitHub commit: 8c31c9a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 17, 2026
@luisherranz
Copy link
Member Author

Thanks (as always), Weston! Committed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants