fix(storybook-angular): resolve experimentalZoneless in Vitest path#2059
Merged
brandonroberts merged 1 commit intoanalogjs:betafrom Feb 10, 2026
Merged
Conversation
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
palexcast
force-pushed
the
fix/storybook-zoneless-vitest
branch
from
89a3bf6 to
e0f99a0
Compare
palexcast
force-pushed
the
fix/storybook-zoneless-vitest
branch
from
e0f99a0 to
08901f8
Compare
The preset checked options.angularBuilderOptions.experimentalZoneless to skip zone.js injection, but this property is never populated when running via @storybook/addon-vitest. Added 3-tier resolution: framework options from .storybook/main.ts, builder options (existing), Angular 21+ auto-detection. Closes analogjs#2058 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
palexcast
force-pushed
the
fix/storybook-zoneless-vitest
branch
from
08901f8 to
666e03e
Compare
brandonroberts
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2058
What is the current behavior?
The storybook-angular preset checks
options.angularBuilderOptions.experimentalZonelessto decide whether to skipzone.jsinjection. This property is populated by the Angular builder executors (start-storybook/build-storybook), but is never set when tests run via@storybook/addon-vitest. As a result, zoneless Angular apps are forced to installzone.jsjust to run Vitest-based Storybook tests.What is the new behavior?
The preset resolves
experimentalZonelessthrough a 3-tier fallback:framework.options.experimentalZonelessin.storybook/main.ts(new, works with@storybook/addon-vitest)options.angularBuilderOptions.experimentalZoneless(existing path, unchanged)@storybook/angularbuilder behavior)Users can now configure zoneless in
.storybook/main.ts:Does this introduce a breaking change?
No. The existing
angularBuilderOptionspath is unchanged. The new tiers only activate when the builder option is absent.Other information
@storybook/addon-vitest#1832 (reporter confirmed the Vitest path still requiredzone.js)experimentalZonelessto theFrameworkOptionstypeFull transparency: This PR was pair-programmed with Claude Opus 4.6 (Anthropic's AI), who did the typing while a human did the thinking. The human filed the issue, designed the 3-tier approach, and caught every shortcut the AI tried to take during review. The AI's main contribution was not complaining about resolving the same merge conflict three times.