Conversation
0510458 to
d978b29
Compare
21a2c0d to
867693a
Compare
7b070cf to
4bfdd1b
Compare
824a8b2 to
2654ecb
Compare
2654ecb to
419d1fa
Compare
Contributor
Author
|
This PR is already being used by other folks, so if no one has anything they want to flag I'll merge as is |
This was referenced May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take on fixing slug issues in #523
Added a bunch more tests, both around
wp_insert_postand the Rest API to give a bit more confidence to this PR.To Test
The following should all be captured in the automated tests, but for manually testing:
Do this for posts and pages
In Classic Editor & In Block Editor
In Classic Editor & In Block Editor
In Classic Editor & In Block Editor
*Repeat this but make the page a child page
In Classic Editor & In Block Editor
*Repeat this but make the page a child page