Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional#19507
Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional#19507
Conversation
af6ae16 to
b567701
Compare
|
@mhegazy Let's get this in for the 2.6 release. |
|
Following #19455 (comment), we should also change the API version |
|
we also need that in release-2.6 |
|
@Andy-MS we need to port this to release-2.6 and add a note about it in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes |
…s non-optional (#19507) * Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional * Increment servicesVersion * Update api baselines
|
Thanks @mhegazy to have pinged me about this change. Is it possible to describe which methods change their signature at https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes (it seems that it's just for completion) In https://github.com/angelozerr/tslint-language-service we override only |
|
@angelozerr Added the method names. If your code compiles that should mean that you don't need to change anything. |
|
Thanks a lot @Andy-MS ! |
Fixes #19455 (comment)