At <div x=/**/, completion insertText should be wrapped in braces#21372
Merged
2 commits merged intomasterfrom Jan 25, 2018
Merged
At <div x=/**/, completion insertText should be wrapped in braces#213722 commits merged intomasterfrom
<div x=/**/, completion insertText should be wrapped in braces#213722 commits merged intomasterfrom
Conversation
Member
|
How does this work with string literal completions in these locations? |
Author
|
|
mhegazy
approved these changes
Jan 24, 2018
Contributor
|
@Andy-MS can you also port this to release-2.7 as well. |
Author
ghost
force-pushed
the
completionsJsxAttributeInitializer
branch
from
caf23d6 to
9f25d82
Compare
ghost
force-pushed
the
completionsJsxAttributeInitializer
branch
from
9f25d82 to
0488325
Compare
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jan 25, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Jan 25, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21341
Includes a fix from #21330 but I would prefer #21342, so must wait on that to merge before merging this.