Remove jake (hopefully for real this time)#29085
Conversation
|
Oooooo that feeling when you put |
|
I would like to keep jake around until > gulp
> gulpHas the second invocation run fast, just like jake does today. |
|
|
|
Well... |
|
This should wait on |
|
Do you need to add the change to support using LKG on CI that we added to jake? |
|
I'm doing something a little different - one second, just validating it a bit. |
… accept older baseline style to go with lkgd build
|
There we go - rather than disabling lkg on CI (which leads to frustrating test diffs locally), I'm now running a sanity check built/local build on CI only after tests pass. |
|
Node 6 is now out in favour of node 11, so that's one more obstacle out of the way. |
|
Alright, looks like everything is now green. Anyone wanna peek over the CI logs to see that you're OK with the now gulp-based ones and give this the 👍? |
| private typeAcquisition; | ||
| updateGraph(): boolean; | ||
| getExcludedFiles(): readonly NormalizedPath[]; | ||
| getExcludedFiles(): ReadonlyArray<NormalizedPath>; |
There was a problem hiding this comment.
I thought this had already been addressed in #29783?
There was a problem hiding this comment.
I un-addressed it to make the nightlies build again.
|
Alright. All build pipelines are on |
|
Wooo, it‘’s scared me.（bye jake） |
|
@weswigham how do you have incremental builds now? |
|
Our gulpfile is shelling out to |
5 participants
A couple of our build tasks will need to be updated, too; but I think this should be all that's needed in TS itself.