Skip to content

Move later Heartbeat minimalInterval conversion to microseconds#2361

Closed
remyperona wants to merge 1 commit intoWordPress:trunkfrom
wp-media:fix/heartbeat-interval
Closed

Move later Heartbeat minimalInterval conversion to microseconds#2361
remyperona wants to merge 1 commit intoWordPress:trunkfrom
wp-media:fix/heartbeat-interval

Conversation

@remyperona
Copy link

Move the minimalInterval valu conversion to microseconds later to avoid setting an incorrect value of mainInterval when mainInterval is inferior to minimalInterval

Trac ticket: https://core.trac.wordpress.org/ticket/54825

Copy link
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterwilsoncc
Copy link
Contributor

Committed in https://core.trac.wordpress.org/changeset/53226 with some slight shuffling of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants