This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Fix showing component source when React Hot Loader is enabled#1191
Closed
macku wants to merge 1 commit intofacebook:masterfrom
macku:fix-showing-source-when-rhl-is-enabled
Closed
Fix showing component source when React Hot Loader is enabled#1191macku wants to merge 1 commit intofacebook:masterfrom macku:fix-showing-source-when-rhl-is-enabled
macku wants to merge 1 commit intofacebook:masterfrom
macku:fix-showing-source-when-rhl-is-enabled
Conversation
macku
commented
Oct 23, 2018
| window.${globalPathToType}.prototype.isReactComponent | ||
| ) { | ||
| inspect(window.${globalPathToInst}.render); | ||
| if (window.${globalPathToInst}.REACT_HOT_LOADER_RENDERED_GENERATION) { |
Author
There was a problem hiding this comment.
The REACT_HOT_LOADER_RENDERED_GENERATION property is assigned by React Hot Loader. Thanks to this property we can know that we are running RHL.
There was a problem hiding this comment.
It would not work for SFC, as long they are not in the prototype.
The only way to access "original" component is to use window.${globalPathToInst}.__reactstandin__getCurrent(link), but this is something react-dev-tools should not rely on.
|
Would be fixed in Rect 4.5.0 via option |
|
Probably you can close this issue now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with a
Show <Component> Sourcefeature when you are running React with React Hot Loader. After selecting the option from a context menu, you will be navigated to a React Hot LoaderProxyFacadecomponent instead of the source of a selected component.How to reproduce?
Appcomponent on the Elements tabShow App SourceCurrent behavior
Devtools are activating Source tab and highlighting
ProxyFacadethat is coming from React Hot Loader.Expected behavior
Devtools should go to the Source tab and highlight the source of
Appcomponent.Demo