fix(svelte): Custom icon reset class on update#4126
Closed
sukram230799 wants to merge 1 commit intoframework7io:masterfrom
Closed
fix(svelte): Custom icon reset class on update#4126sukram230799 wants to merge 1 commit intoframework7io:masterfrom
sukram230799 wants to merge 1 commit intoframework7io:masterfrom
Conversation
616ca61 to
5e7ef1c
Compare
Member
|
Thank you! The fix should be done in a bit different way, so i pushed the new fix for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I dynamically change a custom icon (themeIcon), the class would be appended instead of replaced. This is because we only set the class to
trueviaclasses[value] = true;but never delete the old classes that are no longer passed as arguments. To fix this, I just replace the classes object with a new one.Example before change of pinnedState
Example wrong
Example correct