fix(panel): fix panel close routine if it was closed immediately#4127
Merged
nolimits4web merged 1 commit intoframework7io:masterfrom Feb 2, 2023
Merged
fix(panel): fix panel close routine if it was closed immediately#4127nolimits4web merged 1 commit intoframework7io:masterfrom
nolimits4web merged 1 commit intoframework7io:masterfrom
Conversation
fixes framework7io#4108 (again) In practice, the time until the transition start is variable depending on the browser, amongst other things. Android + Chrome is between 27 => 44ms with a fast phone, but can take longer under many circumstances. This removes the hardcoded time and instead looks for the transition start.
Contributor
Author
|
Thanks for the quick review and merge @nolimits4web Just wanted to note, the Dom7 library in Framework7 core will need to be bumped to the new 4.0.5 release to ensure the new method is available 😅 |
Member
|
Yes, it should be there in F7 7.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4108 (again)
In practice, the time until the transition start is variable depending on the browser, amongst other things. Android + Chrome is between 27 => 44ms with a fast phone, but can take longer under many circumstances.
This removes the hardcoded time and instead looks for the transition start.
Depends on the new
transitionStartmethod added to Dom7 in nolimits4web/dom7#62