feature/postgresql fulltext search #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion 1. PHPBB3-9730
…ion 2. PHPBB3-9730
…ion 3. PHPBB3-9730
Contributor
There was a problem hiding this comment.
We should take this out I think.
Contributor
There was a problem hiding this comment.
The message probably should be "incompatible database (engine)" instead of "version".
Contributor
There was a problem hiding this comment.
Can phpbb_version_compare be used here?
Contributor
|
I don't really like the html in https://github.com/phpbb/phpbb3/pull/832/files#L0R777 |
Contributor
Author
|
@nickvergessen yeah the html does look a little bad, we can move it to a new file. |
1 similar comment
Contributor
There was a problem hiding this comment.
All properties should have access control specifiers (private/public).
Contributor
|
In order for this pr to be merged, search query display needs to be fixed. Whatever was entered by the user for the search query should be displayed in the search box. When I tested this last + were added to words and when nothing was found the query was cleared. |
Fixes braces in fulltext_postgres.php to comply with phpbb conventions. PHPBB3-9730
Some changes in code to get it work against current develop. PosgreSQL Fulltext search works for new install now. PHPBB3-9730
config entries are now added by database_update.php as well. PostgreSQL will work during update too. PHPBB3-9730
Changes to comply with other backend conventions. include $user as global variable to access it inside init(); PHPBB3-9730
removes backward compatibility before PostgreSQL ver 8.3 if version is before 8.3 displays error. PHPBB3-9730
Blank array is assigned to stats incase pgsql fulltext search backend is not compatible PHPBB3-9730
Variable name used is now tsearch_usable instead of tsearch_builtin to reflect its actual purpose. PHPBB3-9730
Use phpBB's built in function for checking PCRE lib support. PHPBB3-9730
Remove the usage of mbstring regex engine when PCRE does not support UTF8 since its a requirement for phpbb 3.1 PHPBB3-9730
…arch Language is changed according to the current PostgreSQL documentation. PHPBB3-9730
PCRE UTF8 support is already checked globally. adds an option of pgsql version to acp. PHPBB3-9730
Language key name not incompatible_database instead of version which was misleading PHPBB3-9730
version_compare is used for version comparision and pgsql version is now a global variable that is displayed in the acp too. PHPBB3-9730
Unused Code for phrase search removed as pgsql doesnt support it. An added message is displayed if user tries to perform exact phrase search. PHPBB3-9730
Docblocks are added to the functions of this search backend. PHPBB3-9730
adds proper spaces after control keywords and comment symbol PHPBB3-9730
In database_update.php each config value of postgres fulltext search is first checked whether it already exists or not and then added. PHPBB3-9730
Contributor
Author
|
Fixed everything. |
function to return the value of the the private property phrase_search PHPBB3-9730
p
added a commit
to p/phpbb3
that referenced
this pull request
Jul 7, 2012
…arch' into develop * dhruvgoel92/feature/postgresql-fulltext-search: (28 commits) [feature/postgresql-fulltext-search] supports_phrase_search function [feature/postgresql-fulltext-search] use proper variable name [feature/postgresql-fulltext-search] each config is checked if it is set [feature/postgresql-fulltext-search] fix formatting [feature/postgresql-fulltext-search] add docblocks to functions [feature/postgresql-fulltext-search] remove phrase search code [feature/postgresql-fulltext-search] define access control specifiers [feature/postgresql-fulltext-search] use version_compare [feature/postgresql-fulltext-search] fix language key [feature/postgresql-fulltext-search] remove Readme [feature/postgresql-fulltext-search] removes pcre check [feature/postgresql-fulltext-search] fix language tsearch2 to text search [feature/postgresql-fulltext-search] remove mbstring support [feature/postgresql-fulltext-search] change language for pgsql < 8.3 [feature/postgresql-fulltext-search] use phpbb_pcre_utf8_support() [feature/postgresql-fulltext-search] fix variable name [feature/postgresql-fulltext-search] Fix version comparison for 9.0+. [feature/postgresql-fulltext-search] fixing license [feature/postgresql-fulltext-search] assign empty stats [feature/postgresql-fulltext-search] remove backward compatibility ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates PostgreSQL Fulltext Search backend into PHPBB Core.
http://tracker.phpbb.com/browse/PHPBB3-9730
PHPBB3-9730