GH-119812: ipaddress: Consider 100.64.0.0/10 private#119813
Open
jstasiak wants to merge 1 commit intopython:mainfrom
Open
GH-119812: ipaddress: Consider 100.64.0.0/10 private#119813jstasiak wants to merge 1 commit intopython:mainfrom
jstasiak wants to merge 1 commit intopython:mainfrom
Conversation
As explained in the linked ticket I believe making an exception for this range is likely to create problems and result in surprises considering: 1. The is_global/is_private relationship in that one is the opposite of the other, except for 100.64.0.0/10 until now 2. is_private returns True for ranges that IANA declares as not globally reachable and 100.64.0.0/10 is defined as being not globally reachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in the linked ticket I believe making an exception for this range is likely to create problems and result in surprises considering:
📚 Documentation preview 📚: https://cpython-previews--119813.org.readthedocs.build/