bpo-36346: Prepare for removing the legacy Unicode C API.#12409
Closed
serhiy-storchaka wants to merge 32 commits intopython:mainfrom
Closed
bpo-36346: Prepare for removing the legacy Unicode C API.#12409serhiy-storchaka wants to merge 32 commits intopython:mainfrom
serhiy-storchaka wants to merge 32 commits intopython:mainfrom
Conversation
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and USE_UNICODE_WCHAR_CACHE. USE_UNICODE_WCHAR_CACHE makes the interpreter not using the wchar_t cache and the legacy Unicode C API. HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the legacy Unicode C API that depends on it.
serhiy-storchaka
requested review from
a team,
rhettinger and
skrah
as code owners
scoder
reviewed
Mar 18, 2019
Contributor
scoder
left a comment
scoder
left a comment
There was a problem hiding this comment.
Wow, that's a lot of code that will eventually be removed here. Nice!
Member
|
@serhiy-storchaka Would you split this pull request? |
Member
Author
|
methane
reviewed
Jul 6, 2020
blesnatalman
approved these changes
Jul 10, 2020
blesnatalman
approved these changes
Jul 10, 2020
blesnatalman
approved these changes
Jul 10, 2020
Member
|
https://bugs.python.org/issue36346 is closed. What is the status of this PR? |
Member
Author
|
No longer actual after merging #92537. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.
USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.
HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.
https://bugs.python.org/issue36346