gh-116738: Audit thread-safety for termios module#138395
Closed
yoney wants to merge 1 commit intopython:mainfrom
Closed
gh-116738: Audit thread-safety for termios module#138395yoney wants to merge 1 commit intopython:mainfrom
yoney wants to merge 1 commit intopython:mainfrom
Conversation
Member
I don't understand the purpose of this PR. If no code change is needed, I suggest closing the PR. |
Contributor
Author
@vstinner Thank you for your feedback! Sorry for any confusion, my intention wasn’t to land this diff. I created this PR mainly as a placeholder to mark the Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a placeholder PR to mark the
termiosmodule as audited in gh-116738 for thread safety in the free-threading build.termiosare marked as MT-Safe in the Linux termios(3). There are no thread safety issues noted in the POSIX documentation.Py_BEGIN_ALLOW_THREADSandPy_END_ALLOW_THREADSwhich assumes they are thread-safe.cc: @mpage @colesbury @Yhg1s
Note: This PR will be closed after termios is marked in gh-116738