gh-141004: Document remaining pyport.h utility macros
#144279
+96
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
topic-C-API
needs backport to 3.13
picnixz
reviewed
Jan 28, 2026
Doc/c-api/intro.rst
Outdated
Comment on lines
191
to
192
| *type* is the type of the expression. In modern versions of Python, this is | ||
| unused. Historically, *type* was used to cast *integer*. |
Member
There was a problem hiding this comment.
Can we reformulate this more precisely through a versionchanged? And indicate that the parameter is unused and kept for backward compatibility?
Member
Author
There was a problem hiding this comment.
There's already a versionchanged that specifies this below.
Member
There was a problem hiding this comment.
Oh sorry. In this case, I think we can just say that it's not used anymore and only kept for BC. The change has been done in 3.1 so whatever is after 3.1 is already "modern" Python.
vstinner
reviewed
Feb 3, 2026
|
|
||
| *value*, *larger*, and *smaller* may all be evaluated more than once in the | ||
| expression; consequently, do not pass an expensive operation directly to | ||
| this macro. |
Member
There was a problem hiding this comment.
Expressions with side effects (ex: value++) should also be avoided.
Co-authored-by: Victor Stinner <[email protected]>
ZeroIntensity
commented
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--144279.org.readthedocs.build/en/144279/c-api/intro.html#useful-macros