bpo-36670: fixed encoding issue with libregrtest on win systems#16456
Closed
LorenzMende wants to merge 1 commit intopython:masterfrom
Closed
bpo-36670: fixed encoding issue with libregrtest on win systems#16456LorenzMende wants to merge 1 commit intopython:masterfrom
LorenzMende wants to merge 1 commit intopython:masterfrom
Conversation
detailed: alternative solution - only works on english systems, default of 0.0 load is returned
Member
|
This change only hides the bug, but i doesn't fix it. I merged PR #16511 which fix this bug, but also multiple other regrtest bugfixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative solution to PR 15488 - fixing encoding issue with libregrtest on win systems (non english), load of default 0.0 is returned
Was not easily able to write early (instantiation) raise, instead adding of the encoding works fine.
I am unsure about the closing of the write end of the pipe (l. 62) -> tests fail if the pipe is closed, so I uncommented it.
https://bugs.python.org/issue36670