bpo-36670, regrtest: Fix TestWorkerProcess.stop()#16530
Closed
vstinner wants to merge 2 commits intopython:masterfrom
vstinner:regrtest_lock
Closed
bpo-36670, regrtest: Fix TestWorkerProcess.stop()#16530vstinner wants to merge 2 commits intopython:masterfrom vstinner:regrtest_lock
vstinner wants to merge 2 commits intopython:masterfrom
vstinner:regrtest_lock
Conversation
* Add a RLock to TestWorkerProcess to make stop() reliable when regrtest is interrupted by CTRL+c: protect _popen and _killed attributes. * Fix _kill(): don't set _killed to True if _popen is None. * Fix TestWorkerProcess.__repr__(): start_time is only valid if _popen is not None.
Member
Author
|
I'm not sure if my lock is correct, so I wrote a simpler PR with no lock: PR #16537. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regrtest is interrupted by CTRL+c: protect _popen and _killed
attributes.
if _popen is not None.
https://bugs.python.org/issue36670