Skip to content

bpo-30455: Generate tokens related C code and docs from token.py.#1860

Closed
serhiy-storchaka wants to merge 21 commits intopython:masterfrom
serhiy-storchaka:regen-token
Closed

bpo-30455: Generate tokens related C code and docs from token.py.#1860
serhiy-storchaka wants to merge 21 commits intopython:masterfrom
serhiy-storchaka:regen-token

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 30, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 30, 2017
@mention-bot
Copy link

mention-bot commented May 30, 2017

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @loewis and @tim-one to be potential reviewers.

@matrixise
Copy link
Member

matrixise commented May 31, 2017

@serhiy-storchaka if Parser/token.c is auto-generated by the tool, why do you include it in this PR ?

berkerpeksag
berkerpeksag reviewed Jul 3, 2017
View reviewed changes
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 14, 2018
Closed
@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner April 14, 2018 12:23
@markshannon
Copy link
Member

markshannon commented Jul 29, 2018

Nice cleaning up of the code. Generally LGTM.

Tools/scripts/generate_token_h.py and Tools/scripts/generate_token_rst.py are very similar, it would be neater to merge them.

@pablogsal pablogsal self-assigned this Sep 25, 2018
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Nov 6, 2018

Created alternate PR #10370 which takes all information from Grammar/Tokens and use a single generating script.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Nov 18, 2018

Tools/scripts/generate_token_h.py, Tools/scripts/generate_token_rst.py and Tools/scripts/generate_token_c.py have been merged into Tools/scripts/generate_token.py. See also #10370.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 20, 2018
Merged
2 tasks
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Dec 22, 2018

Closed in favor of #10370.

@serhiy-storchaka serhiy-storchaka deleted the regen-token branch December 22, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag left review comments

Assignees

@pablogsal pablogsal

Labels

awaiting review type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@serhiy-storchaka @mention-bot @matrixise @markshannon @berkerpeksag @brettcannon @Mariatta @pablogsal @the-knights-who-say-ni