Skip to content

[WIP] bpo-40137: Use pep573 in functools extension module.#20055

Closed
shihai1991 wants to merge 2 commits intopython:masterfrom
shihai1991:bpo_40137_functools2
Closed

[WIP] bpo-40137: Use pep573 in functools extension module.#20055
shihai1991 wants to merge 2 commits intopython:masterfrom
shihai1991:bpo_40137_functools2

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 12, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 requested a review from rhettinger as a code owner May 12, 2020 15:18
@shihai1991 shihai1991 marked this pull request as draft May 12, 2020 15:18
@shihai1991 shihai1991 mentioned this pull request May 12, 2020
Merged
corona10
corona10 reviewed May 12, 2020
View reviewed changes
@shihai1991
Copy link
Member Author

shihai1991 commented May 12, 2020

There have a problem what petr have mentioned in #19982: This also only works because the iterator type is not subclassable.(PyType_GetModule can not work if the type is subtype).

vstinner
vstinner requested changes May 14, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

@bedevere-bot
Copy link

bedevere-bot commented May 14, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991
Copy link
Member Author

shihai1991 commented May 14, 2020

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

You are right, the type have tp_new can not worked now : (

@vstinner vstinner closed this May 14, 2020
encukou
encukou reviewed May 15, 2020
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

@encukou encukou encukou left review comments

@corona10 corona10 corona10 left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991 @bedevere-bot @vstinner @encukou @corona10 @the-knights-who-say-ni