bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h#20462
Closed
MatzeB wants to merge 1 commit intopython:mainfrom
Closed
bpo-2897: Make PyMemberDef part of stable ABI; deprecate structmember.h#20462MatzeB wants to merge 1 commit intopython:mainfrom
MatzeB wants to merge 1 commit intopython:mainfrom
Conversation
Move PyMemberDef and related flags from structmember.h to descrobject.h. Rename READONLY to PY_READONLY and READ_RESTRICTED to PY_READ_RESTRICTED. This makes the structure part of the stable ABI. Move PyMember_GetOne and PyMemberSetOne as well but do not make them part of the stable ABI yet. Document that structmember.h is deprecated, change examples and documentation and add definitions for READONLY, READ_RESTRICTED, PY_WRITE_RESTRICTED and RESTRICTED to it for backwards compatibility. Add check for stddef.h to configure.ac because we need to include it for offsetof and Python.h does not pass the HAVE_STDDEF_H check without it.
Member
|
Hello. Sorry for the delay -- I just found this PR (I noticed the bug and wanted to file an issue myself).
|
Contributor
Author
|
Hey, I am currently not working with python so I don't know when I would find the time to push this further. If you or someone else wants to take over, by all means! |
Member
|
Taking over in #99014 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move PyMemberDef and related flags from structmember.h to descrobject.h.
Rename READONLY to PY_READONLY and READ_RESTRICTED to
PY_READ_RESTRICTED. This makes the structure part of the stable ABI.
Move PyMember_GetOne and PyMemberSetOne as well but do not make them
part of the stable ABI yet.
Document that structmember.h is deprecated, change examples and
documentation and add definitions for READONLY, READ_RESTRICTED,
PY_WRITE_RESTRICTED and RESTRICTED to it for backwards compatibility.
Add check for stddef.h to configure.ac because we need to include it for
offsetof and Python.h does not pass the HAVE_STDDEF_H check without it.
https://bugs.python.org/issue2897