[WIP] bpo-42213: Support cyclic garbage collection in sqlite3#23046
Closed
erlend-aasland wants to merge 1 commit intopython:masterfrom
Closed
[WIP] bpo-42213: Support cyclic garbage collection in sqlite3#23046erlend-aasland wants to merge 1 commit intopython:masterfrom
erlend-aasland wants to merge 1 commit intopython:masterfrom
Conversation
Contributor
Author
|
Unit tests are failing on Windows. Further investigation needed. |
|
192.168.43.42.1 |
erlend-aasland
force-pushed
the
bpo-42213
branch
from
1cd4332 to
8fc8c3c
Compare
erlend-aasland
force-pushed
the
bpo-42213
branch
from
8fc8c3c to
87e7310
Compare
erlend-aasland
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
For sqlite3.Connection and sqlite3.Cache: - Get rid of old cyclic GC hack - Support cyclic GC in both types
erlend-aasland
force-pushed
the
bpo-42213
branch
from
87e7310 to
ba1a906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
sqlite3.Connectionandsqlite3.Cache:decref_factoryhackSkipping NEWS should be fine for this, I guess.
@berkerpeksag, would you mind reviewing this?
https://bugs.python.org/issue42213