[WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements#24492
Closed
erlend-aasland wants to merge 15 commits intopython:mainfrom
Closed
[WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements#24492erlend-aasland wants to merge 15 commits intopython:mainfrom
erlend-aasland wants to merge 15 commits intopython:mainfrom
Conversation
Contributor
Author
|
Cherry-picked from #13216 and rebased onto master. |
Also add additional assertion covering ALTER statements.
Feature added in sqlite 3.7.4, not .11.
|
This PR is stale because it has been open for 30 days with no activity. |
erlend-aasland
changed the title
added 2 commits
June 5, 2021 21:00
erlend-aasland
force-pushed
the
bpo-36859
branch
3 times, most recently
from
ba8d1e6 to
dce7ada
Compare
MaxwellDupre
suggested changes
Apr 4, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Ran 18 tests in 0.481s
OK
Other Sqlite tests also passed. Looks ok.
Need to add to Docs, not just NEWS otherwise users will not be aware.
erlend-aasland
changed the title
Contributor
Author
|
I'm not sure this is the correct way to address to the problems in the linked issue. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81040